Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --ignore-certificate-errors to default chromeFlags #3

Closed
djusv opened this issue Dec 31, 2018 · 6 comments
Closed

Add --ignore-certificate-errors to default chromeFlags #3

djusv opened this issue Dec 31, 2018 · 6 comments

Comments

@djusv
Copy link

djusv commented Dec 31, 2018

While trying to run against servers with self signed certificates I noticed that the lighthouse didn't return any values. Adding --ignore-certificate-errors to the default chrome flags worked for me.

@gidztech
Copy link
Contributor

I've just run into this problem myself while running Lighthouse against our app running on a local environment. I'm going to work on this and raise a PR.

@soulgalore
Copy link
Member

Merged this going out in next release.

@gidztech
Copy link
Contributor

gidztech commented Feb 26, 2019

@soulgalore

I actually looked into this in the afternoon and evening and don't have a working solution.

The --ignore-certificate-errors flag that you added will not fix this problem as it doesn't alter the way Devtool Protocol clients, like Lighthouse, see the security state of the website.

I believe it can be done low level by setting Security.setOverrideCertificateErrors({ override: true }); but only from within the Lighthouse client, not as a Chrome flag. That's my understanding.

See GoogleChrome/lighthouse#7292 and GoogleChrome/lighthouse#6655 for more detail.

@soulgalore soulgalore reopened this Feb 27, 2019
@soulgalore
Copy link
Member

Ok thanks for looking into it.

@gidztech
Copy link
Contributor

I raised a PR in the main repository for being able to pass in an additional start script that can import certificates into the container's certificate store as a workaround here.

@soulgalore
Copy link
Member

Cool I guess this is fixed then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants