-
-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebPageTest plugin doesn't work - code 404 #3771
Comments
https://github.com/WebPageTest/webpagetest-api/pull/171/files |
I can help out, but what has changed and when? When I look in https://github.com/WPO-Foundation/webpagetest/tree/apache it looks like the last change was done three years ago. The https://github.com/WebPageTest/webpagetest-api seems to get changes all the time, but it's not versioned (like what version of the API works against which version of WebPageTest and more important what version works agains the Open Source version? |
So then If I understand correctly they intentionally broke the API (by calling it "deprecated" but removing the functionality)? |
Might have confused you a bit with above message, it's still possible to send in the api key via the query, I manually tested setting up the webpagetest plugin and running it in the docker with sitespeed.io image, tho I needed to use an older version because the documentation on sitespeed didn't work with setting up plugins manually. The tests get passed into the webpagetest and I can see the result in there, but I think something is trowing in the try block in the analyzer.js, didn't have time to look further, as I don't have best practice with debugging in such an environment. |
config.json:
pages.txt: |
@soulgalore @Vodrech Can I help you somehow? |
@bgruszka what version of WebPageTest do you run against? I haven't looked yet what changed, I only looked in the API and I wanted to understand if that change killed the Apache branch or maybe I misunderstood. The webpagetest-api isn't versioned, and I think the problem is that if we upgrade it can work again their main branch (I don't remember what they call the main branch) but it will break the Apache branch integration? |
@soulgalore I have used sitespeed.io.26.1.0. It is over a month since it stopped working now (around Feb 8th, 2023), and hence losing metrics to graphana.
Google Chrome 106.0.5249.119
|
@Comeonautomaten what version are you using of WebPageTest? We didn't change anything in the API so I think it broke because of a change in WebPageTest? |
@soulgalore I do not know the exact version of WebPageTest. I used this image: And, I see this merge request on WebPageTest: catchpoint/WebPageTest.api-nodejs#171 |
If I understand it correctly this is what has happened: WebPageTest runs un-versionen and without a changelog in the master branch. The WebPageTest version got updated or autoupdated, the API doesn't work anymore since WebPageTest doesn't version handle the API against the WebPageTest server. The version of the WebPageTest API work against the Apache branch (or any of you using the Apache branch?). When that PR will be merged, it will work for WebPageTest API users that do tests against the master branch. Is that correct? I don't want to update the WebPageTest API so we break compatibility against the Apache-branch? |
Do you run private instances of WebPageTest? I tried to get an up and running using https://github.com/WPO-Foundation/webpagetest/tree/master/docker/local - I can make it run, but couldn't connect to the API, I always get the " Could not run test for WebPageTest {"statusCode":400,"statusText":"Invalid API key. To continue running tests via the WebPageTest API, you'll need to update your current key for the enhanced WebPageTest API. Read more here: https://product.webpagetest.org/api"" error. |
Hello once again, I tried to follow the newly updated docs that you created, it was very beneficial, but somehow it seem like I'm doing something wrong. I'm having trouble with adding the webpagetest plugin, I could not figure out if this actually was one of the 'default' plugins or not, but I tried both adding it via the Image: sitespeedio/sitespeed.io:27.3.0-webpagetest
config.json
|
Hi @Vodrech hmm I think I missed updating the documentation for the plugin when sitespeed.io 27.0.0 was released. I fixed that now. If you use the prebuilt container the plugin path is /webpagetest/index.js |
Hi, The issue seems to be fixed.
|
Hi @Comeonautomaten thanks of sharing, it seems there was a bug then at the WebPageTest side. |
Have you read the documentation?
URL
https://www.onet.pl/
What are you trying to accomplish
I want to run sitespeed with WebPageTest plugin enabled, but unfortunately I have this:
{"name":"WPTAPIError","code":404,"message":"Not Found"}
I set proper API key.
What browser did you use?
Other
How to reproduce
Relevant log output
The text was updated successfully, but these errors were encountered: