Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing API key with headers #171

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Passing API key with headers #171

merged 1 commit into from
Apr 19, 2023

Conversation

Siddhantshukla814
Copy link
Contributor

The key won't be passed by query params anymore it will be passed with the headers

@Siddhantshukla814
Copy link
Contributor Author

@tkadlec Could you please guide if this is the correct way of doing this, I'm not sure if this the right practice in this particular case, but it works.

@Siddhantshukla814 Siddhantshukla814 changed the title Passing the key in headers Passing API key with headers Feb 15, 2023
Copy link
Contributor

@jefflembeck jefflembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should do the trick.

Noting here, passing the query param still works, this is just the option we're moving toward as the standard. We still are supporting the legacy way of passing api keys.

@Siddhantshukla814 Siddhantshukla814 merged commit e0cbd59 into master Apr 19, 2023
@Siddhantshukla814
Copy link
Contributor Author

Thanks @jefflembeck I totally forgot about this one, this PR is up since our API started accepting key with headers.
Yes, from user perspective we are not changing anything, It's just our wrapper which will pass key with the headers not with the query params with every request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants