Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rationale to README #2

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Add rationale to README #2

merged 1 commit into from
Feb 22, 2022

Conversation

zemanlx
Copy link
Contributor

@zemanlx zemanlx commented Jan 26, 2022

I have got flagged by your linter today and was confused for a while. If there is a rationale why this technique is suboptimal it would be helpful, hence this PR.

@sivchari
Copy link
Owner

Sorry too late reponse 😢
This PR is so good, so I approve it.

@sivchari sivchari merged commit bd932c8 into sivchari:main Feb 22, 2022
@zemanlx zemanlx deleted the patch-1 branch February 22, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants