migration to Symfony 3.4 for long-term support #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 23, 2017 19:12
ParisLiakos
requested changes
Mar 22, 2018
| @@ -113,5 +117,5 @@ knp_snappy: | |||
| pdf: | |||
| enabled: true | |||
| # Edit this to change the location of wkhtmltopdf binary. | |||
| #binary: /usr/local/bin/wkhtmltopdf #"\"C:\\Program Files\\wkhtmltopdf\\bin\\wkhtmltopdf.exe\"" for Windows users | |||
There was a problem hiding this comment.
Please undo these changes before i can merge the PR :)
| @@ -113,5 +117,5 @@ knp_snappy: | |||
| pdf: | |||
| enabled: true | |||
| # Edit this to change the location of wkhtmltopdf binary. | |||
| #binary: /usr/local/bin/wkhtmltopdf #"\"C:\\Program Files\\wkhtmltopdf\\bin\\wkhtmltopdf.exe\"" for Windows users | |||
| options: [] | |||
| binary: /usr/bin/xvfb-run /usr/bin/wkhtmltopdf | |||
| @@ -9,6 +9,7 @@ class SiwappCoreTwigExtension extends \Twig_Extension | |||
| protected $bundles; | |||
|
|
|||
| public function __construct(array $bundles) { | |||
|
|
|||
| protected $em; | ||
|
|
||
| public function __construct(EntityManager $em) | ||
| public function __construct(EntityManagerInterface $em) |
| */ | ||
| public function __construct() | ||
| { | ||
| $this->reference = 'P'.date("Y").mt_rand(10000,99999); |
There was a problem hiding this comment.
Also irrelevant i think? Can we please get this in a separate PR and discuss there?
| */ | ||
| private $session; | ||
|
|
||
| public function __construct(Session $session) | ||
| public function __construct(SessionInterface $session) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i fixed all dépraciation for a migration to Symfony 3.4.
I modified some files css for a more modern look.
I fixed some bugs like for "class LoadEstimate".