fixing template where we want to override nested attribute value #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually I'm going to release version |
|
Sorry guys, we'll need to release |
|
Looks good. |
|
Thank you @ahirata :) |
nykolaslima
added a commit
that referenced
this pull request
Jan 29, 2015
fixing template where we want to override nested attribute value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In immutable objects, when we try to override a nested attribute in the
gimmecall it doesn't work.Now, after create the object with all property definitions, we take the properties that were not used in the constructor and starting processing then as deferred properties.
@ahirata @aparra can you guys review it please?
After merging it I'm going to release a fix version
2.2.1