Skip to content

Commit

Permalink
Do NOT fail CI if codecov runs into errors during upload (GenericMapp…
Browse files Browse the repository at this point in the history
…ingTools#1032)

The codecov github action is very unstable recently, and make most of
our CI jobs fail.

This PR sets `fail_ci_if_error` to `false` (the default behavior of
codecov), so that even if codecov fails in uploading the coverage
reports, the CI job still pass.

Actually, if the codecov upload fails, we will see the failing codecov
checks, but at least we know that all tests pass.

[skip ci]
  • Loading branch information
seisman authored and Josh Sixsmith committed Dec 21, 2022
1 parent 401e105 commit b0bed40
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ jobs:
with:
file: ./coverage.xml # optional
env_vars: OS,PYTHON
fail_ci_if_error: true
fail_ci_if_error: false

- name: Checkout the gh-pages branch
uses: actions/checkout@28c7f3d2b5162b5ddd3dfd9a45aa55eaf396478b
Expand Down

0 comments on commit b0bed40

Please sign in to comment.