Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dialog object to Setting property #28

Closed
iamqiz opened this issue Apr 25, 2024 · 3 comments
Closed

Add dialog object to Setting property #28

iamqiz opened this issue Apr 25, 2024 · 3 comments
Assignees
@Vanessa219

Comments

@iamqiz
Copy link
Contributor

iamqiz commented Apr 25, 2024

Clip_2024-04-25_17-13-04

目前的痛点: 对话框没有id,只能通过class等方式获取, 不知道是不是唯一的
@Vanessa219
Copy link
Member

加一个 dialog 是否够用了？
image

@iamqiz
Copy link
Contributor Author

iamqiz commented May 20, 2024

@Vanessa219 都加上吧, setting对象里, 和回调函数参数里

@Vanessa219
Copy link
Member

自身的属性，回调里面就不加了。

@Vanessa219 Vanessa219 self-assigned this May 22, 2024
Vanessa219 added a commit to siyuan-note/siyuan that referenced this issue May 22, 2024
@Vanessa219
🎨 fix siyuan-note/petal#28
a339144
@Vanessa219 Vanessa219 changed the title [需求] setting类Callback传入对话框元素 Add dialog object to Setting property May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Vanessa219 @iamqiz