Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When New document save location is configured as /, it will be completed as /Untitled #10305

Closed
3 tasks done
kyota-iino opened this issue Feb 3, 2024 · 0 comments
Closed
3 tasks done
Assignees
Milestone

Comments

@kyota-iino
Copy link

kyota-iino commented Feb 3, 2024

New document tabs do not appear in notebooks with specific conditions

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

Notebooks can be configured to set the path where new documents are generated. The name of the setting is New document save location. By default, this is left blank, but if you specify only /, there will be problems when creating a new document in that notebook.

The problem occurs when a document is created directly under a notebook in DocTree using the + to the right of the notebook's name. A new document is created, but the document does not appear in the tabs. Normally, when you type in the name of the document, the corresponding tab does not exist.

Also, when opening a document immediately below this new document in DocTree, the editor may be split. However, this behavior seems to depend on the state of the tabs when the document is newly created, and may or may not reproduce itself.

Expected result

It was quite a while ago that I made this setting, so I am not sure why I entered only /, but it seems that I probably wanted the default name of the document to be placed directly under the notebook, so I made this setting.

Screenshot or screen recording presentation

000
Set the location of the new document to / in the notebook settings.

001
Create a document from the icon next to the notebook in the Doc tree.

002
No corresponding tab is created for new documents.

If a document immediately below in the Doc tree is opened in this state, the editor will be opened in a split state. However, this seems to depend on the status of the previous tabs.

Screenshot from 2024-02-04 03-18-56

Version environment

- Version: v2.12.6
- Operating System: Pop!_OS 22.04 LTS (Ubuntu 22.04 LTS Based)
- Machine: x86_64 CPU (AMD Ryzen 9 7940HS)
- Browser (if used):

Log file

I was monitoring workspace/temp/siyuan.log while reproducing this problem, but no specific logs were output.

More information

I personally do not consider this to be a serious problem, as I have found that restoring the settings for this problem to their default values resolves the problem.
However, for a while I was restarting every time I created a new document without knowing that this setting was the cause.

@88250 88250 changed the title New document tabs do not appear in notebooks with specific conditions When New document save location is configured as /, it will be completed as /Untitled Feb 4, 2024
@88250 88250 assigned 88250 and unassigned Vanessa219 Feb 4, 2024
@88250 88250 added this to the 2.12.7 milestone Feb 4, 2024
88250 added a commit that referenced this issue Feb 4, 2024
@88250 88250 closed this as completed Feb 4, 2024
@siyuan-note siyuan-note deleted a comment from Moe39118 Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants