Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the direction of text, table columns, and horizontal overflow #11455

Closed
3 tasks done
CyRamos opened this issue May 18, 2024 · 12 comments
Closed
3 tasks done

Improve the direction of text, table columns, and horizontal overflow #11455

CyRamos opened this issue May 18, 2024 · 12 comments
Assignees
Milestone

Comments

@CyRamos
Copy link

CyRamos commented May 18, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

Hey team,
RTL user over here.
When I grab some block of text (for example let's say it's a headline) and drag it next to another block on the left
It changes the order of the text in the wrong direction.

Wrong Example from SiYuan:

image

image

Expected result

Expected result from Notion:

image

image

Screenshot or screen recording presentation

No response

Version environment

- Version: v3.0.14
- Operating System: Windows 11 Pro
- Browser (if used): Brave, however, I'm using most with the desktop version. If it's necessary I'll use the web version.

Log file

siyuan.log

More information

No response

@TCOTC
Copy link
Contributor

TCOTC commented May 19, 2024

I can reproduce this

RTL.webm

@CyRamos
Copy link
Author

CyRamos commented May 19, 2024

I can reproduce this

RTL.webm

Hey @TCOTC
Thanks for the answer, I didn't mention however this feature is also enabled in my workspace.
image

in your video, it seems there is the same issue (when you drag the block left it appears in the right)

@88250 88250 assigned 88250 and Vanessa219 and unassigned 88250 May 21, 2024
@CyRamos
Copy link
Author

CyRamos commented May 22, 2024

Hey team
Another mention: when writing in English (General RTL enabled in Editor but in document align to left).
The punctuation is also upside down:

image
image

@Vanessa219 Vanessa219 added this to the 3.0.16 milestone May 23, 2024
Vanessa219 added a commit that referenced this issue May 23, 2024
@Vanessa219 Vanessa219 changed the title 🐛 RTL Rearrange Blocking Do It Wrong Improve the direction of text, table columns, and horizontal overflow May 23, 2024
@Vanessa219
Copy link
Member

This is quite correct for languages written right to left: the terminating punctuation mark appears at the end, i.e. on the left.

@CyRamos
Copy link
Author

CyRamos commented May 23, 2024

This is quite correct for languages written right to left: the terminating punctuation mark appears at the end, i.e. on the left.

If it helps for references - in the Notion app where the blocks are auto-rotated (attach photo below)
when it's RTL or LTR it's known to rotate the block automatically.

image

@Vanessa219
Copy link
Member

Rotation may not solve the problem, RTL is also language dependent.

@forabi
Copy link

forabi commented Jun 6, 2024

Most apps which support auto-direction use some heuristics (if the paragraph starts with an RTL language character, this paragraph will be in RTL). Applying this setting to the whole editor is not very useful because most people will have to write some text in LTR languages along with RTL text in the same document.

@Vanessa219
Copy link
Member

We can use the block menu to set each block individually.

image

@CyRamos
Copy link
Author

CyRamos commented Jun 21, 2024

We can use the block menu to set each block individually.

image

Glad to hear that does it mean in the future the text will automatically be RTL / LTR based on the block?

@Vanessa219
Copy link
Member

This requires manual setting, there is no automatic setting rule.

@CyRamos
Copy link
Author

CyRamos commented Jun 24, 2024

This requires manual setting, there is no automatic setting rule.

I see, first of all, thanks for the answer
Second - this is the current result for choosing in-block RTL / LTR (as mentioned above) + aligning the text right (ALT+R)

image

As we can see the numeric lists are just changing their directions instead be in the right of the document:
image

@Vanessa219
Copy link
Member

Because there is a block operation on 1., only the paragraph block has rtl.
It is normal when previewing.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants