Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve image width setting #12516

Closed
TCOTC opened this issue Sep 18, 2024 · 8 comments
Closed

Improve image width setting #12516

TCOTC opened this issue Sep 18, 2024 · 8 comments
Assignees
@88250 @Vanessa219
Labels
Enhancement
Milestone
3.1.14

Comments

@TCOTC
Copy link
Contributor

TCOTC commented Sep 18, 2024 •
edited by 88250
Loading

图片宽度问题

关联 #12423

01 比例问题

之前是按编辑器的宽度，所以四张 25% 宽度的图片刚好可以排放在一个块内。

现在是按窗口的宽度，之前的图片排版就都乱了。

02 图片标题宽度问题

https://ld246.com/article/1727180114061
image

会导致标题宽度超过图片宽度，然后菜单按钮和光标都会偏移：

image
@TCOTC TCOTC changed the title 图片宽度比例问题 图片宽度问题 Sep 24, 2024
@TCOTC
Copy link
Contributor Author

TCOTC commented Sep 24, 2024

@Vanessa219 我觉得图片宽度的这个问题影响比较大

@TCOTC
Copy link
Contributor Author

TCOTC commented Oct 16, 2024 •
edited
Loading

用户反馈汇总：

@88250 88250 self-assigned this Oct 22, 2024
@88250 88250 added this to the 3.1.11 milestone Oct 22, 2024
@88250 88250 modified the milestones: 3.1.11, 3.1.12 Nov 3, 2024
@88250 88250 changed the title 图片宽度问题 Improve image width setting Nov 9, 2024
@88250 88250 modified the milestones: 3.1.12, 3.1.13, 3.1.14 Nov 18, 2024
Vanessa219 added a commit that referenced this issue Nov 28, 2024
@Vanessa219
🎨 #12516
0d161fd
Vanessa219 added a commit that referenced this issue Nov 28, 2024
@Vanessa219
🎨 #12516
d9a527a
Vanessa219 added a commit that referenced this issue Nov 28, 2024
@Vanessa219
🎨 #12516
c8d44b0
Vanessa219 added a commit that referenced this issue Nov 28, 2024
@Vanessa219
🎨 #12516
736c09f
88250 added a commit to 88250/lute that referenced this issue Nov 28, 2024
@88250
🎨 Protyle Improve image width setting siyuan-note/siyuan#12516
47c361d
@88250 88250 closed this as completed Nov 28, 2024
@Misuzu2027
Copy link
Contributor

Misuzu2027 commented Nov 30, 2024 •
edited
Loading

我试了下 v3.1.14-dev5 版本，发现给图片设置高度还是给 img 标签修改样式，F5 刷新后会发现修改图片高度没有生效。 @Vanessa219

@TCOTC
Copy link
Contributor Author

TCOTC commented Nov 30, 2024

宽度也有问题

video.webm

@88250
Copy link
Member

88250 commented Dec 1, 2024

稍后调整

88250 added a commit to 88250/lute that referenced this issue Dec 1, 2024
@88250
🎨 Protyle Improve image width setting siyuan-note/siyuan#12516
35cc811
88250 added a commit that referenced this issue Dec 1, 2024
@88250
🎨 Improve image width setting #12516
6c7c737
88250 added a commit to 88250/lute that referenced this issue Dec 1, 2024
@88250
🎨 Protyle Improve image width setting siyuan-note/siyuan#12516 siyuan…
83b4fa1 
…-note/siyuan#13327
88250 added a commit that referenced this issue Dec 1, 2024
@88250
🎨 Improve image width setting #12516 #13327
715ecc5
@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 2, 2024

四张 25% 宽度的图片放在一起还是会挤下去一个：

image

@pisceswb
Copy link

pisceswb commented Dec 3, 2024

https://ld246.com/article/1733232175688
3 张宽度为 33% 的图片，不能在同一排中

@wish5115
Copy link

wish5115 commented Dec 3, 2024

https://ld246.com/article/1733232175688 3 张宽度为 33% 的图片，不能在同一排中

我这边32%就好了，图片之间可能有些间距啥的吧，如果你那边有问题可以再小点试试。

EightDoor added a commit to EightDoor/siyuan that referenced this issue Dec 6, 2024
@EightDoor
Merge commit '1710194122495d282a51650441d9fc80804561bb'
6cbce45 
* commit '1710194122495d282a51650441d9fc80804561bb': (189 commits)
  🔖 Release v3.1.14
  ⬆️ Upgrade kernel deps
  🎨 siyuan-note#13320
  🎨 Support HarmonyOS NEXT system
  🎨 Support HarmonyOS NEXT system
  🎨 Support HarmonyOS NEXT system
  🎨 Support HarmonyOS NEXT system
  🎨 Support HarmonyOS NEXT system
  🎨 Support HarmonyOS NEXT system
  🎨 Support HarmonyOS NEXT system
  🎨 siyuan-note#13334
  🎨 siyuan-note#13181
  🎨 Improve exporting block ref siyuan-note#13283
  🎨 Clean code
  🐛 Fix NPE
  📝 Update changelogs
  🎨 siyuan-note#13324
  🐛 Fix NPE
  🎨 Improve image width setting siyuan-note#12516 siyuan-note#13327
  🧑‍💻 Kernel serve CalDAV service on path `/caldav/` (siyuan-note#13321)
  ...

# Conflicts:
#	README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@88250 88250

@Vanessa219 Vanessa219

Labels
Enhancement
Projects
None yet
Milestone
3.1.14
Development

No branches or pull requests
6 participants
@88250 @Vanessa219 @wish5115 @TCOTC @pisceswb @Misuzu2027