Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve document tree movement and its animation #12914

Closed
TCOTC opened this issue Oct 26, 2024 · 10 comments
Closed

Improve document tree movement and its animation #12914

TCOTC opened this issue Oct 26, 2024 · 10 comments
Assignees
Milestone

Comments

@TCOTC
Copy link
Contributor

TCOTC commented Oct 26, 2024

优化文档树移动及其动画

default.webm
  1. 在点击收起的一瞬间不应该上升,在视觉上会有不必要的闪烁:

    default.webm
  2. 在点击展开的一瞬间不应该消失,在视觉上会有不必要的闪烁(另外那个删除图标也会闪一下,不过好像没法禁用这个 hover 样式,所以没那么有所谓):

    default.webm
@SaXz2
Copy link

SaXz2 commented Oct 28, 2024

可以顺带改进一下文档树的拖拽显示吗,文档数量多了以后会更加的闪烁
示例1
PixPin_2024-10-28_12-59-20
示例2
recording

@siyuan-note siyuan-note deleted a comment Oct 28, 2024
Vanessa219 added a commit that referenced this issue Oct 31, 2024
Vanessa219 added a commit that referenced this issue Oct 31, 2024
@Vanessa219
Copy link
Member

@SaXz2 第一点可以优化。但第二点由于排序规则的不确定,需要刷新父列表。

@Vanessa219 Vanessa219 added this to the 3.1.11 milestone Oct 31, 2024
Vanessa219 added a commit that referenced this issue Oct 31, 2024
@Vanessa219 Vanessa219 changed the title 改进点击 已关闭的笔记本 的动画 优化文档树移动及其动画 Oct 31, 2024
@88250 88250 changed the title 优化文档树移动及其动画 Improve document tree movement and its animation Oct 31, 2024
@SaXz2
Copy link

SaXz2 commented Oct 31, 2024

@SaXz2 第一点可以优化。但第二点由于排序规则的不确定,需要刷新父列表。

希望未来可以得到改善,文档数量多了以后,拖拽不停的刷新体验实在是不太好,并且刷新完都会被折叠

@TCOTC
Copy link
Contributor Author

TCOTC commented Oct 31, 2024

我新建工作空间之后遇到了缩不下去的情况(重载界面后恢复正常):

default.webm

Vanessa219 added a commit that referenced this issue Nov 1, 2024
Vanessa219 added a commit that referenced this issue Nov 1, 2024
@Vanessa219
Copy link
Member

@SaXz2 好的,再改进一下

Vanessa219 added a commit that referenced this issue Nov 1, 2024
@SaXz2
Copy link

SaXz2 commented Nov 2, 2024

先感谢V姐,经过dev8测试不涉及以下两点效果已经非常完美了。

  • 拖动大纲以后会导致文档树刷新
  • 拖动大纲以后折叠的大纲会全部展开

@TCOTC
Copy link
Contributor Author

TCOTC commented Nov 2, 2024

@SaXz2 我想起来了,你是不是始终展开大纲了:

image

如果打开了这个就是会始终展开的,关掉就行。

@SaXz2
Copy link

SaXz2 commented Nov 2, 2024

才发现这个,昨天讨论半天原来问题出在这,难怪你复现不了

@TCOTC
Copy link
Contributor Author

TCOTC commented Nov 2, 2024

拖动大纲以后会导致文档树刷新

@Vanessa219 这个确实是,目前文档树会刷新了再展开,这个场景实际不应该刷新的

Vanessa219 added a commit that referenced this issue Nov 2, 2024
@Vanessa219
Copy link
Member

已修复

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants