New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The backlink panel supports filtering by the block attributes #12985

Closed

SaXz2 opened this issue Oct 31, 2024 · 29 comments

Assignees

Labels

Milestone

SaXz2 commented Oct 31, 2024 •

edited by 88250

Loading

反链面板过滤文档名

In what scenarios do you need this feature?

示例：

文档名：张强
内容：[[生日]] XXXX...

但是反链过滤，不能按照文档名去过滤，过滤张强就是空的了。

Describe the optimal solution

直接在原有基础上添加文档名的检索，不会影响别的内容。

Describe the candidate solution

No response

Other information

No response

88250 self-assigned this

88250 added the Enhancement label

88250 changed the title ~~反链面板过滤文档名~~ The backlink panel supports filtering by the document name

88250 added this to the 3.1.12 milestone

88250 added a commit that referenced this issue


          🎨 The backlink panel supports filtering by the document name #12985

597c166

88250 closed this as completed

Author

SaXz2 commented Nov 11, 2024

测试体验：可以再次增强搜索命中命名、别名、备注、标签等其他属性使用体验会更加好

参考：Misuzu2027/syplugin-backlink-panel#20

对比图：

88250 changed the title ~~The backlink panel supports filtering by the document name~~ The backlink panel supports filtering by the document attributes

88250 changed the title ~~The backlink panel supports filtering by the document attributes~~ The backlink panel supports filtering by the block attributes

Member

88250 commented Nov 11, 2024

收到，稍后加上。

88250 added a commit that referenced this issue


          🎨 The backlink panel supports filtering by the block attributes #12985

ea3f5fa

Author

SaXz2 commented Nov 13, 2024

1.测试了新版没有生效
检索属性检索不出来

2.应该去掉大小写检测

3.不能过滤出属性中的缺字(虽然是插件但是原版应该也测试一下)

4.支持过滤出代码块中的这里，建议直接改成匹配到的都列出来不管是嵌入块还是代码块只要肉眼能看到都匹配过滤出来

Author

SaXz2 commented Nov 13, 2024 •

edited

Loading

补充一条：代码块过滤出来不会显示高亮（仔细一看，底下的也没高亮）

Member

88250 commented Nov 13, 2024

没太看懂……

Author

SaXz2 commented Nov 13, 2024 •

edited

Loading

没太看懂……

我也不知道该怎么描述，就现在这个过滤很奇怪。更准确点说是

给无序列表中段落添加属性就无法被过滤
过滤的内容应该高亮显示，现在有些显示有些不显示（例如：代码属性加了样式的字体）估计还有很多
代码块中的语言也应该被搜索过滤出来
应该取消大小写区分
无法描述
给属性添加别名 → 讨论不同笔记软件的使用逻辑和优缺点
搜索 → 讨论不同笔记软件的使用逻辑 → 可以被过滤
搜索 → 讨论不同 → 无法被过滤

刚才有点激动了，这回描述的应该准确多了

Member

88250 commented Nov 14, 2024

只有给定义块上添加的属性才过滤，不计算定义块子块的
改进空格分隔关键字高亮
代码块语言搜索搞不了，代码块内容高亮目前也搞不了
ok
和 2 一样，空格分隔

88250 added a commit that referenced this issue


          🎨 The backlink panel supports filtering by the block attributes #12985

c9cac8b

Author

SaXz2 commented Nov 14, 2024

建议再优化一下，我都统一把属性添加到段落块中，不计算的话什么都搜索不出来
可以参考反链面板插件

Member

88250 commented Nov 14, 2024

麻烦制作一个 1 问题的测试数据集我这边调试看看。

2 的话短期内不考虑了改动高亮机制了。

Author

SaXz2 commented Nov 14, 2024

搜索测试.sy (1).zip

这个属性添加的方式应该限制一下，现在有点太过于自由了以至于能最多套个10层

Contributor

TCOTC commented Nov 14, 2024

每个块都是能添加属性的

Member

88250 commented Nov 15, 2024 •

edited

Loading

@SaXz2 调试了下，列表容器块的时候只考虑第一个叶子块的内容匹配，不考虑其他叶子块，否则会和传递规则冲突，所以这里不再改变了，谢谢。

顺便发现个问题，之前的容器块匹配用的是 content 过滤，实际上应该用 fcontent 过滤，这样才统一规则（使用第一个子块内容过滤）。

88250 added a commit that referenced this issue


          🎨 The backlink panel supports filtering by the block attributes #12985

0d3d6df

Author

SaXz2 commented Nov 18, 2024

有一些显示BUG，目前会变成这样

用了主题以后会这样

TCOTC mentioned this issue

Improve search highlighting #13178

Closed

Contributor

TCOTC commented Nov 18, 2024

关联 #13178

Author

SaXz2 commented Nov 19, 2024 •

edited

Loading

@88250 D大再搞一搞吧，经过测试这个版本目前用起来很麻烦21个反链中只能过滤出6个，连最基本的静态锚文本都无法被过滤出来

Member

88250 commented Nov 19, 2024

这个图片我没看懂，麻烦做个最小化测试数据集。

Author

SaXz2 commented Nov 19, 2024

召唤一下米大@Misuzu2027 来探讨一下，刚才看了一眼米大的说明，过滤逻辑上有些复杂，我已经有点搞不清楚了，稍后我再做一份新的测试数据集

米大的说明

Contributor

Misuzu2027 commented Nov 19, 2024 •

edited

Loading

@88250 我这里看到的问题是 api/ref/getBacklinkDoc 接口在默认查询，参数 keyword: ""时，每个字符都的中间加上了 span 标签。。

其他的是我对反链块关键字匹配属性不同场景的描述，跟官方的不一定通用。

88250 mentioned this issue

Incorrect backlink keyword highlighting #13210

Closed

Member

88250 commented Nov 20, 2024

@Misuzu2027 感谢指出问题，下个版本修复 #13210

Author

SaXz2 commented Nov 20, 2024

新的测试数据
合并测试.sy.zip

Member

88250 commented Nov 20, 2024

@SaXz2 搜索的问题是因为没有在当前块上，这个不会考虑改动了。

Author

SaXz2 commented Nov 20, 2024 •

edited

Loading

不对啊D大，3.1.13版本过滤不了段落块，以前的版本是可以的，这个过滤效果肯定是不应该的

正常效果应该是除了书签都能命中

这是siyuan-v202411131823-win的效果

Member

88250 commented Nov 20, 2024

哦哦，不好意思，我只看了列表那个例子，段落的例子确实有问题，稍后调整。

88250 added a commit that referenced this issue


          🎨 The backlink panel supports filtering by the block attributes #12985

247b534

Temacc0531 commented Nov 26, 2024 •

edited

Loading

v3.1.14 dev3现在好像过滤不了列表子块，这个是正常的吗

[[记录]]
- 工作a
- 工作b

在记录的反链里面过滤a还是b都搜不出东西

Member

88250 commented Nov 26, 2024

@Temacc0531 #12985 (comment)

Temacc0531 commented Nov 26, 2024

@Temacc0531 #12985 (comment)

嘶，我这个不是还挺常见的用法吗，有什么替代方案吗😯

Member

88250 commented Nov 26, 2024

恐怕是没有，看下社区插件？

Temacc0531 commented Nov 26, 2024

恐怕是没有，看下社区插件？

传递规则冲突是啥意思来的，按我的理解都显示出来了就应该支持过滤吧，属性那些隐藏字段都可以，显示出来的反倒过滤不了

Member

88250 commented Nov 26, 2024

新开一个 issue 吧

Temacc0531 mentioned this issue

The backlink panel supports filtering by child blocks #13275

Closed

3 tasks

88250 added a commit that referenced this issue


          🎨 The backlink panel supports filtering by child blocks #13275 #12985

148a270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment