Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports click PlantUML diagram hyperlink #13801

Closed
3 tasks done
kjgino opened this issue Jan 12, 2025 · 1 comment
Closed
3 tasks done

Supports click PlantUML diagram hyperlink #13801

kjgino opened this issue Jan 12, 2025 · 1 comment
Assignees
Milestone

Comments

@kjgino
Copy link

kjgino commented Jan 12, 2025

PlantUML diagram hyperlink doesn't work

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

PlantUML diagram is shown as a picture only, so even hyperlink is shown in PlantUML diagram, it doesn't work.

Expected result

Clicking hyperlink, then SiYuan shall show specified url.

Screenshot or screen recording presentation

For example, if a->b:message([[https://www.google.com/ here shall be a link to google]]) is described in PlantUML, SiYuan shows like attached image, it is Ok. However, hyperlink doesn't work.

image

Version environment

- Version: 3.1.19
- Operating System: Microsoft Windows 11 Pro
- Browser (if used): no use

Log file

siyuan.log

More information

Simple fix is already available from myside, if it is ok I can make PR.

@88250 88250 added this to the 3.1.20 milestone Jan 13, 2025
@88250 88250 changed the title PlantUML diagram hyperlink doesn't work Supports click PlantUML diagram hyperlink Jan 13, 2025
@Vanessa219
Copy link
Member

参照 Vanessa219/vditor#1579 进行修改

Vanessa219 added a commit that referenced this issue Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants