Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute "data-key" for Dialog #10138

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

mdzz2048
Copy link
Contributor

  • Please commit to the dev branch
  • For contributing new features, please supplement and improve the corresponding user guide documents
  • For bug fixes, please describe the problem and solution via code comments
  • For text improvements (such as typos and wording adjustments), please submit directly

给使用 new Dialog() 创建的弹窗添加 data-key 属性。

app\src\menus\onGetnotebookconf.tsapp\src\history\history.ts 只修改了非移动端的 dialog

@Vanessa219 Vanessa219 added this to the 2.12.3 milestone Jan 10, 2024
@Vanessa219 Vanessa219 merged commit 291211b into siyuan-note:dev Jan 10, 2024
1 check passed
@mdzz2048 mdzz2048 deleted the add-data-key branch January 10, 2024 14:32
@Vanessa219
Copy link
Member

这几个是不是没有用到?
image

Vanessa219 added a commit that referenced this pull request Jan 10, 2024
Vanessa219 added a commit that referenced this pull request Jan 10, 2024
@mdzz2048
Copy link
Contributor Author

这几个是不是没有用到? image

重命名的时候没注意改对应的文件,我看您最新的提交已经改好了,抱歉抱歉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants