Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pagination navigation fix #12552 #12563 #12567

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

TCOTC
Copy link
Contributor

@TCOTC TCOTC commented Sep 23, 2024

  1. 打开窗口时会先显示带 ${x} ${y} 的文本,等查询完之后才将 ${x} ${y} 替换为数字,导致不必要的闪烁。所以改为先隐藏,替换后再显示
  2. jumpRepoPage 和 jumpHistoryPage 的实现方式改为一致的

@TCOTC TCOTC marked this pull request as ready for review September 23, 2024 15:51
@TCOTC TCOTC changed the title Improve pagination navigation Improve pagination navigation fix #12552 #12563 Sep 23, 2024
@TCOTC
Copy link
Contributor Author

TCOTC commented Sep 23, 2024

还有一个按钮中的数字会被选择的问题我不懂怎么处理:

default.webm

@88250
Copy link
Member

88250 commented Sep 23, 2024

可以合并了吗?等合并了 @Vanessa219 看看

@TCOTC
Copy link
Contributor Author

TCOTC commented Sep 23, 2024

可以合并了

@88250 88250 merged commit a8f183a into siyuan-note:dev Sep 23, 2024
@TCOTC TCOTC deleted the dev-Improve-pagination-navigation branch September 23, 2024 16:06
Vanessa219 added a commit that referenced this pull request Sep 24, 2024
Vanessa219 added a commit that referenced this pull request Sep 24, 2024
Vanessa219 added a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants