Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve database attribute panel style #13248

Merged
merged 12 commits into from
Nov 27, 2024
Merged

Conversation

TCOTC
Copy link
Contributor

@TCOTC TCOTC commented Nov 24, 2024

改进数据库属性面板样式

改进了问题:

  1. 主键文本向左突出
  2. 创建时间和更新时间字段不需要 hover 样式,因为跟主键文本一样不能点击、不能编辑
  3. 空白字段需要添加占位符 https://ld246.com/article/1732420221578/comment/1732426954817#comments

image

占位符参考 Notion:

image

  1. 添加字段按钮也改了一下,之前的有点突兀:

image

@TCOTC TCOTC marked this pull request as draft November 24, 2024 06:51
@TCOTC TCOTC marked this pull request as ready for review November 24, 2024 09:37
@TCOTC TCOTC marked this pull request as draft November 24, 2024 10:54
@TCOTC TCOTC marked this pull request as ready for review November 24, 2024 11:16
@Vanessa219 Vanessa219 merged commit f716e16 into siyuan-note:dev Nov 27, 2024
@Vanessa219 Vanessa219 self-requested a review November 27, 2024 12:51
@TCOTC TCOTC deleted the dev-av-style branch November 27, 2024 13:30
TCOTC added a commit to TCOTC/siyuan that referenced this pull request Nov 27, 2024
引号搞错了
@TCOTC TCOTC mentioned this pull request Nov 27, 2024
Vanessa219 added a commit that referenced this pull request Nov 27, 2024
@Vanessa219 Vanessa219 added this to the 3.1.14 milestone Nov 27, 2024
@Vanessa219 Vanessa219 self-assigned this Nov 27, 2024
@TCOTC
Copy link
Contributor Author

TCOTC commented Nov 27, 2024

hover 字段名的时候要不也变灰(或者变亮)?

image

@TCOTC
Copy link
Contributor Author

TCOTC commented Nov 27, 2024

还有鼠标划过去感觉有点不跟手,我觉得还是不要这两个 transition 了:

.custom-attr .b3-text-field--text {
    transition: var(--b3-transition);
}

.custom-attr__avvalue {
    transition: var(--b3-transition);
}

Vanessa219 added a commit that referenced this pull request Nov 28, 2024
@Vanessa219
Copy link
Member

收到,已提交

@88250 88250 changed the title 改进数据库属性面板样式 Improve database attribute panel style Nov 28, 2024
@TCOTC
Copy link
Contributor Author

TCOTC commented Nov 28, 2024

@Vanessa219 这里也用 --b3-background-transition

image

Vanessa219 added a commit that referenced this pull request Nov 28, 2024
88250 added a commit that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants