Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve drag block to database highlighting #13284

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

TCOTC
Copy link
Contributor

@TCOTC TCOTC commented Nov 26, 2024

fix #13251


还有一个问题需要解决,但我不会改:

  • 拖拽块(或当前数据库条目)到 .av__row--util 元素上时,应该在前一个元素(也就是最后一个 .av__row 元素)上添加 .dragover__bottom 类名
  • 目前会在 .av__row--util 元素上添加 .dragover__top 或 .dragover__bottom 类名,不符合预期

另外,是两个都用 ::before 或者 ::after,还是一个用 ::before 另一个用 ::after ,我拿不定主意

@Vanessa219 Vanessa219 merged commit 18f68ac into siyuan-note:dev Nov 27, 2024
3 checks passed
@TCOTC TCOTC deleted the dev-av-dragover branch November 27, 2024 12:02
Vanessa219 added a commit that referenced this pull request Nov 27, 2024
@Vanessa219
Copy link
Member

修改了一下。

都使用 ::after;试了一下好像不会加到 av__row--util

@Vanessa219 Vanessa219 self-requested a review November 27, 2024 12:44
@Vanessa219 Vanessa219 added this to the 3.1.14 milestone Nov 27, 2024
@TCOTC
Copy link
Contributor Author

TCOTC commented Nov 27, 2024

我这里是会的:

video.webm

@TCOTC
Copy link
Contributor Author

TCOTC commented Nov 27, 2024

这条线看起来有点偏上,可以往下一点点:

image

Vanessa219 added a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants