-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using the middle button to close a tab triggers pasting on Linux #13395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vanessa219
reviewed
Dec 8, 2024
Vanessa219
reviewed
Dec 9, 2024
app/src/layout/Wnd.ts
Outdated
@@ -101,11 +101,25 @@ export class Wnd { | |||
window.siyuan.menus.menu.remove(); | |||
event.stopPropagation(); | |||
event.preventDefault(); | |||
// 阻止 Linux 中键粘贴 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这样好像也不对,有些 Linux 没有这个问题,而且还有伺服后在浏览器中使用的情况。
88250
changed the title
解决Linux中使用中键关闭标签页时会触发粘贴的问题(#13309)
Using the middle button to close a tab triggers pasting on Linux
Dec 10, 2024
Vanessa219
reviewed
Dec 10, 2024
}, 250); | ||
|
||
// 保持原有焦点 | ||
if (activeElement instanceof HTMLElement) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
activeElement 看上去和 document.activeElement 在这个事件内看上去都是同一个变量,我这里没有环境,不知道实际上的情况,还麻烦解释一下。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
解决Linux中使用中键关闭标签页时会触发粘贴的问题(#13309)
Feature or bug? 特性或者缺陷?
解决#13309 中提到的问题,通过在关闭标签页操作中拦截粘贴事件解决该问题,这样不会影响其他场景下的中键粘贴功能
现有问题
Linux中,使用中键关闭标签页时会触发中键粘贴功能,如下视频所示:
Now.mp4
修复后在X11上的测试
X11.mp4
修复后在Wayland上的测试
wayland.mp4