Avoid window controls overlay covering SiYuan toolbar buttons #13771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
稍等，我需要再改一下，应当使用margin-left而不是修改现有的padding-left。 |
|
edit: 我本地直接 squash + rebase 到当前 dev 分支最新提交了。 |
Since we already declares "window-controls-overlay" in our PWA manifest file, we also need to care about the actual place taken by the window controls overlay. See also: - https://web.dev/articles/window-controls-overlay Resolve: siyuan-note#13226
88250
changed the title
|
感谢你的贡献，思源有你更精彩！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we already declares "window-controls-overlay" in our PWA manifest file, we also need to care about the actual place taken by the window controls overlay.
See also:
Resolve: #13226
Screenshot after patch:
Feature or bug? 特性或者缺陷？
Bug. 缺陷。
Multilingual or copywriting? 多语言或者文案？
文案无关。
Dev branch!
已核查目标分支为 dev。