Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: 改进字号 CSS 和列表项的伪元素布局 #13959

Merged
merged 5 commits into from
Jan 30, 2025
Merged

style: 改进字号 CSS 和列表项的伪元素布局 #13959

merged 5 commits into from
Jan 30, 2025
+10 −7

Conversation

TCOTC
Copy link
Contributor

@TCOTC TCOTC commented Jan 27, 2025 •
edited
Loading

  • CSS 使用 --b3-font-size-editor 变量，插件或主题能直接使用或者修改
  • 修了一下编辑器字号小于 14px 时列表项圆点的伪元素 margin 不对导致错位的问题

@TCOTC TCOTC changed the title style: 添加 --b3-font-size-editor 变量 style: 改进字号 CSS 和列表项的伪元素布局 Jan 29, 2025
Vanessa219
Vanessa219 reviewed Jan 29, 2025
View reviewed changes
app/src/util/assets.ts
@@ -288,12 +288,10 @@ export const setInlineStyle = async (set = true) => {
}`;
}
}
style += `.b3-typography, .protyle-wysiwyg, .protyle-title {font-size:${window.siyuan.config.editor.fontSize}px !important}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不能删

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我感觉没什么影响？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

字体大小的设置

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我这里感觉没问题

image

Copy link
Member

@Vanessa219 Vanessa219 Jan 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哦，没注意到前面的

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还麻烦再解决一下冲突

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好了

@Vanessa219 Vanessa219 merged commit 698698e into siyuan-note:dev Jan 30, 2025
2 checks passed
@Vanessa219 Vanessa219 added this to the 3.1.21 milestone Jan 30, 2025
@TCOTC TCOTC deleted the dev-font-size branch January 30, 2025 03:52
Vanessa219 added a commit that referenced this pull request Jan 30, 2025
@Vanessa219
🎨 #13959
31acfe9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vanessa219 Vanessa219 Vanessa219 left review comments

Assignees

@Vanessa219 Vanessa219

@TCOTC TCOTC

Labels
Development
Projects
None yet
Milestone
3.1.21
Development

Successfully merging this pull request may close these issues.
2 participants
@TCOTC @Vanessa219