Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin event bus open-menu-inbox #9967

Conversation

Zuoqiu-Yingyi
Copy link
Contributor

  • Please commit to the dev branch

添加收集箱面板菜单打开事件
Added inbox panel menu open event

TESTED

@88250 88250 requested a review from Vanessa219 December 25, 2023 07:16
@Vanessa219
Copy link
Member

看代码只是初始化的时候会触发,再次打开并不会触发。

@Zuoqiu-Yingyi
Copy link
Contributor Author

看代码只是初始化的时候会触发,再次打开并不会触发。

这里的 初始化再次打开 具体是指什么情况? 我暂时没遇到过不能触发的情况

@Vanessa219
Copy link
Member

多次点击 inbox 图标

@Zuoqiu-Yingyi
Copy link
Contributor Author

多次点击 inbox 图标

我这里基于 v2.11.4-dev6 的版本一切正常
思源笔记-功能示范-42

@Vanessa219
Copy link
Member

抱歉抱歉,是我看错了。

@Vanessa219 Vanessa219 added this to the 2.12.0 milestone Dec 26, 2023
@Vanessa219 Vanessa219 merged commit a47e477 into siyuan-note:dev Dec 26, 2023
1 check passed
@Zuoqiu-Yingyi Zuoqiu-Yingyi deleted the feat/plugin-event-bus-open-menu-inbox branch December 26, 2023 05:31
Vanessa219 added a commit to siyuan-note/petal that referenced this pull request Dec 26, 2023
Vanessa219 added a commit to siyuan-note/plugin-sample that referenced this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants