Minor clean-up

sjanel · Jan 18, 2025 · 4cf5aa7 · 4cf5aa7
1 parent 6c6adcc
commit 4cf5aa7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/trading/common/include/market-trader-engine.hpp b/src/trading/common/include/market-trader-engine.hpp
@@ -25,7 +25,7 @@ class MarketTraderEngine {
   MarketTraderEngine(const schema::ExchangeConfig &exchangeConfig, Market market, MonetaryAmount startAmountBase,
                      MonetaryAmount startAmountQuote);
 
-  Market market() const { return {_startAmountBase.currencyCode(), _startAmountQuote.currencyCode()}; }
+  Market market() const { return _market; }
 
   void registerMarketTrader(std::unique_ptr<AbstractMarketTrader> marketTrader);
 

diff --git a/src/trading/common/src/market-trader-engine.cpp b/src/trading/common/src/market-trader-engine.cpp
@@ -54,8 +54,6 @@ namespace {
 
 template <class VectorType>
 TradeRangeResultsStats ValidateRange(VectorType &vec, TimePoint earliestPossibleTime) {
-  using std::erase_if;
-
   using ObjType = std::remove_cvref_t<decltype(*std::declval<VectorType>().begin())>;
 
   static_assert(std::is_same_v<ObjType, MarketOrderBook> || std::is_same_v<ObjType, PublicTrade>);
@@ -66,6 +64,7 @@ TradeRangeResultsStats ValidateRange(VectorType &vec, TimePoint earliestPossible
 
   stats.nbSuccessful = static_cast<decltype(stats.nbSuccessful)>(vec.size());
 
+  using std::erase_if;
   const auto nbInvalidObjects = erase_if(vec, [](const auto &obj) { return !obj.isValid(); });
   if (nbInvalidObjects != 0) {
     log::error("{} {}(s) with invalid data detected", nbInvalidObjects, kObjName);