Skip to content

Commit

Permalink
🐛 Update the label for the Tag field on the Application Form
Browse files Browse the repository at this point in the history
Resolves: konveyor#1410
Follows up: konveyor#1408

  - The application form will only show manual tags (i.e. source="")

  - All tags are allowable for selection as a manual tag

  - Change the label on the field from "Tags" to "Manual Tags" to
    match the "Manual" grouping of tags in the application drawer

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
  • Loading branch information
sjd78 committed Oct 3, 2023
1 parent e73d2b3 commit fda9438
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions client/public/locales/en/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,7 @@
"label": "Label",
"loading": "Loading",
"lowRisk": "Low risk",
"manualTags": "Manual Tags",
"maintainers": "Maintainers",
"mavenConfig": "Maven configuration",
"mediumRisk": "Medium risk",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export const ApplicationForm: React.FC<ApplicationFormProps> = ({

const nonManualTags = application?.tags?.filter((t) => t.source !== "") ?? [];

// TODO: Filter this if we want to exclude non-manual tags from manual tag selection
// Allow all tags to be selected manually, even if they are included from another source
const allowedManualTags = tags;

const getBinaryInitialValue = (
Expand Down Expand Up @@ -364,7 +364,7 @@ export const ApplicationForm: React.FC<ApplicationFormProps> = ({
items={allowedManualTags}
control={control}
name="tags"
label={t("terms.tags")}
label={t("terms.manualTags")}
fieldId="tags"
noResultsMessage={t("message.noResultsFoundTitle")}
placeholderText={t("composed.selectMany", {
Expand Down

0 comments on commit fda9438

Please sign in to comment.