Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image inline resizable issue #231

Merged
merged 6 commits into from
Jun 24, 2024

Conversation

semanticist21
Copy link
Contributor

Fix issue related with #211

I moved 'mousdown' state value to the parent and improved selected logic.
I added some comment on the code.

Tested on with both option inline true and false, and it worked fine for me.

added mouse down event on image resizing.
@semanticist21
Copy link
Contributor Author

semanticist21 commented Jun 21, 2024

@sjdemartini
May you look up or review this pull request to be merged?
I am currently using mui-tiptap by editing codes by myself due to this bug.
I hope to use it in an offical version soon.

@sjdemartini
Copy link
Owner

@semanticist21 Thanks for investigating a fix and making the PR. I'll plan on looking at this and testing it out soon and will get back to you.

@semanticist21
Copy link
Contributor Author

Thank you.
Give me any feedback to fix if needed!

added mouse down event on image resizing.
@semanticist21 semanticist21 deleted the feature/temp branch June 22, 2024 13:48
@semanticist21 semanticist21 restored the feature/temp branch June 23, 2024 03:35
@semanticist21
Copy link
Contributor Author

restored branch

@semanticist21 semanticist21 reopened this Jun 23, 2024
@semanticist21
Copy link
Contributor Author

restored mistakenly deleted branch.

@semanticist21 semanticist21 reopened this Jun 23, 2024
@sjdemartini
Copy link
Owner

Thanks again @semanticist21! Good find and clever solution. It's a bit odd to me that Tiptap removes the selected state of the node when dragging the resize handle only when inline: true, but this does seem to work for both inline: true and inline: false and seems like a reasonable solution to me!

@sjdemartini sjdemartini merged commit 48804e6 into sjdemartini:main Jun 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants