-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: image inline resizable issue #231
Conversation
added mouse down event on image resizing.
@sjdemartini |
@semanticist21 Thanks for investigating a fix and making the PR. I'll plan on looking at this and testing it out soon and will get back to you. |
Thank you. |
added mouse down event on image resizing.
ef3f383
to
05a6167
Compare
restored branch |
added mouse down event on image resizing.
84f9143
to
62160d8
Compare
a370219
to
5d604aa
Compare
restored mistakenly deleted branch. |
Thanks again @semanticist21! Good find and clever solution. It's a bit odd to me that Tiptap removes the |
Fix issue related with #211
I moved 'mousdown' state value to the parent and improved selected logic.
I added some comment on the code.
Tested on with both option inline true and false, and it worked fine for me.