36 tidal integration #38
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvillegasd
reviewed
Dec 1, 2024
Comment on lines
+16
to
+17
| ADMIN_NAME: 'Admin' | ||
| ADMIN_API_KEY: 'E7gWaEu8JOIGKR/jTmOOgbmBCup2h48jmux2YvIzpxk=' |
Comment on lines
+10
to
+28
| export enum Adapter { | ||
| Spotify = StreamingService.Spotify, | ||
| YouTube = StreamingService.YouTube, | ||
| AppleMusic = StreamingService.AppleMusic, | ||
| Deezer = StreamingService.Deezer, | ||
| SoundCloud = StreamingService.SoundCloud, | ||
| Tidal = StreamingService.Tidal, | ||
| } | ||
|
|
||
| export enum Parser { | ||
| Spotify = 'spotify', | ||
| YouTube = 'youTube', | ||
| AppleMusic = 'appleMusic', | ||
| Deezer = 'deezer', | ||
| SoundCloud = 'soundCloud', | ||
| Spotify = StreamingService.Spotify, | ||
| YouTube = StreamingService.YouTube, | ||
| AppleMusic = StreamingService.AppleMusic, | ||
| Deezer = StreamingService.Deezer, | ||
| SoundCloud = StreamingService.SoundCloud, | ||
| Tidal = StreamingService.Tidal, | ||
| } | ||
|
|
||
| export type StreamingServiceType = Adapter & Parser; |
There was a problem hiding this comment.
Since Parser and Adapter are basically the same enum, you could remove one of them to keep one source of truth
Comment on lines
104
to
114
| if (metadata.type === MetadataType.Song) { | ||
| const [, artist] = metadata.description.match(/^([^·]+) · Song · \d+$/) ?? []; | ||
| query = artist ? `${query} ${artist}` : query; | ||
| } | ||
|
|
||
| if (metadata.type === MetadataType.Album) { | ||
| const [, artist] = metadata.description.match(/(.+?) · Album ·/) ?? []; | ||
|
|
||
| query = artist ? `${query} ${artist}` : query; | ||
| } | ||
|
|
||
| if (metadata.type === MetadataType.Playlist) { | ||
| query = `${query.replace(/This is /, '')} Playlist`; | ||
| [, artist] = metadata.description.match(/^([^·]+)\s+·/) ?? []; | ||
| } else if (metadata.type === MetadataType.Album) { | ||
| [, artist] = metadata.description.match(/^([^·]+)\s+·/) ?? []; | ||
| } else if (metadata.type === MetadataType.Podcast) { | ||
| [, artist] = metadata.description.match(/from\s(.+?)\son\sSpotify\./) ?? []; | ||
| } | ||
|
|
||
| if (metadata.type === MetadataType.Podcast) { | ||
| const [, artist] = metadata.description.match(/from (.+?) on Spotify\./) ?? []; | ||
|
|
||
| query = artist ? `${query} ${artist}` : query; | ||
| } | ||
| const query = artist ? `${parsedTitle} ${artist.trim()}` : parsedTitle; | ||
|
|
||
| return query; |
Comment on lines
+76
to
+83
| const metadataFetchers = { | ||
| [Parser.Spotify]: getSpotifyMetadata, | ||
| [Parser.YouTube]: getYouTubeMetadata, | ||
| [Parser.AppleMusic]: getAppleMusicMetadata, | ||
| [Parser.Deezer]: getDeezerMetadata, | ||
| [Parser.SoundCloud]: getSoundCloudMetadata, | ||
| [Parser.Tidal]: getTidalMetadata, | ||
| }; |
Comment on lines
-21
to
+34
| await page.setUserAgent( | ||
| 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:124.0) Gecko/20100101 Firefox/124.0' | ||
| ); | ||
| try { | ||
| await page.setUserAgent( | ||
| 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:124.0) Gecko/20100101 Firefox/124.0' | ||
| ); |
There was a problem hiding this comment.
For scrapping, I would recommend to randomize User Agent to bypass some anti-scrapping rules (scrapper would fail less)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: replace bun test with
vitest+ add missing fixtures and casescloses #36