Skip to content

Commit

Permalink
fix(ng-repeat): properly detect the end of an ng-repeat-start block
Browse files Browse the repository at this point in the history
This bug was introduced when by.exactRepeater was

Discovered while investigating issue angular#2365
  • Loading branch information
sjelin committed Nov 9, 2015
1 parent 97e6703 commit 7cba4ec
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions lib/clientsidescripts.js
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ function findRepeaterRows(repeater, exact, index, using) {
var elem = repeatElems[i];
var row = [];
while (elem.nodeType != 8 ||
!repeaterMatch(elem.nodeValue, repeater, exact)) {
!repeaterMatch(elem.nodeValue, repeater)) {
if (elem.nodeType == 1) {
row.push(elem);
}
Expand Down Expand Up @@ -237,7 +237,7 @@ function findAllRepeaterRows(repeater, exact, using) {
if (repeaterMatch(repeatElems[i].getAttribute(attr), repeater, exact)) {
var elem = repeatElems[i];
while (elem.nodeType != 8 ||
!repeaterMatch(elem.nodeValue, repeater, exact)) {
!repeaterMatch(elem.nodeValue, repeater)) {
if (elem.nodeType == 1) {
rows.push(elem);
}
Expand Down Expand Up @@ -291,7 +291,7 @@ function findRepeaterElement(repeater, exact, index, binding, using, rootSelecto
var elem = repeatElems[i];
var row = [];
while (elem.nodeType != 8 || (elem.nodeValue &&
!repeaterMatch(elem.nodeValue, repeater, exact))) {
!repeaterMatch(elem.nodeValue, repeater))) {
if (elem.nodeType == 1) {
row.push(elem);
}
Expand Down Expand Up @@ -390,7 +390,7 @@ function findRepeaterColumn(repeater, exact, binding, using, rootSelector) {
var elem = repeatElems[i];
var row = [];
while (elem.nodeType != 8 || (elem.nodeValue &&
!repeaterMatch(elem.nodeValue, repeater, exact))) {
!repeaterMatch(elem.nodeValue, repeater))) {
if (elem.nodeType == 1) {
row.push(elem);
}
Expand Down

0 comments on commit 7cba4ec

Please sign in to comment.