Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete scale name tests #94

Merged
merged 4 commits into from
Jan 28, 2024
Merged

delete scale name tests #94

merged 4 commits into from
Jan 28, 2024

Conversation

teunbrand
Copy link
Contributor

Hello there,

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break viridis.

Briefly, the scale_name field in scales is now deprecated. The tests that checked the scale name have thus become superfluous, but would still register as broken. This PR deletes the tests that the scale name.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help viridis get out a fix if necessary.

@sjmgarnier
Copy link
Owner

@teunbrand Thanks! I will review the changes and push a new version of viridis to CRAN over the weekend.

@teunbrand
Copy link
Contributor Author

Thanks for the prompt response!

@sjmgarnier sjmgarnier changed the base branch from master to develop January 28, 2024 14:04
@sjmgarnier sjmgarnier merged commit 20e6a9a into sjmgarnier:develop Jan 28, 2024
7 checks passed
@teunbrand teunbrand deleted the ggplot2_3.5.0 branch January 28, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants