Skip to content

fix(security): prevent command injection in test-hook.sh #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sjnims merged 2 commits into from
Dec 13, 2025
Merged

fix(security): prevent command injection in test-hook.sh #148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d8aa53
fix(security): prevent command injection in test-hook.sh
claude Dec 13, 2025
3b29376
fix(security): add TEST_INPUT path validation for defense-in-depth
sjnims Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions plugins/plugin-dev/skills/hook-development/scripts/test-hook.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,16 +141,34 @@ if [ ! -f "$HOOK_SCRIPT" ]; then
exit 1
fi

# Security: Validate hook script path doesn't contain dangerous characters
# This prevents potential command injection through maliciously crafted paths
if [[ "$HOOK_SCRIPT" =~ [\;\|\&\`\$\(\)\{\}\<\>] ]]; then
echo "❌ Error: Hook script path contains invalid characters"
echo " Path must not contain: ; | & \` \$ ( ) { } < >"
exit 1
fi

# Track if we need to invoke with bash explicitly
HOOK_IS_EXECUTABLE=true
if [ ! -x "$HOOK_SCRIPT" ]; then
echo "⚠️ Warning: Hook script is not executable. Attempting to run with bash..."
HOOK_SCRIPT="bash $HOOK_SCRIPT"
HOOK_IS_EXECUTABLE=false
fi

if [ ! -f "$TEST_INPUT" ]; then
echo "❌ Error: Test input not found: $TEST_INPUT"
exit 1
fi

# Security: Validate test input path doesn't contain dangerous characters
# This mirrors the HOOK_SCRIPT validation for defense-in-depth
if [[ "$TEST_INPUT" =~ [\;\|\&\`\$\(\)\{\}\<\>] ]]; then
echo "❌ Error: Test input path contains invalid characters"
echo " Path must not contain: ; | & \` \$ ( ) { } < >"
exit 1
fi

# Validate test input JSON
if ! jq empty "$TEST_INPUT" 2>/dev/null; then
echo "❌ Error: Test input is not valid JSON"
Expand Down Expand Up @@ -187,7 +205,13 @@ echo ""
start_time=$(date +%s)

set +e
output=$(timeout "$TIMEOUT" bash -c "cat '$TEST_INPUT' | $HOOK_SCRIPT" 2>&1)
# Use proper argument passing to prevent command injection
# Arguments are passed safely via bash -c's positional parameters
if [ "$HOOK_IS_EXECUTABLE" = true ]; then
output=$(timeout "$TIMEOUT" bash -c 'cat "$1" | "$2"' -- "$TEST_INPUT" "$HOOK_SCRIPT" 2>&1)
else
output=$(timeout "$TIMEOUT" bash -c 'cat "$1" | bash "$2"' -- "$TEST_INPUT" "$HOOK_SCRIPT" 2>&1)
fi
exit_code=$?
set -e

Expand Down
Loading