refactor: use ERE instead of BRE in grep patterns for clarity#159
Merged
refactor: use ERE instead of BRE in grep patterns for clarity#159
Conversation
Replace escaped alternation (BRE) with grep -E (ERE) for better readability: - `grep -q "a\|b"` → `grep -Eq "a|b"` Changed 11 instances across 2 files: - validate-agent.sh: 2 instances - hook-linter.sh: 9 instances ERE is more readable and widely understood than BRE with escaped pipes. Fixes #154 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
2 tasks
|
Claude finished @sjnims's task in 1m 35s —— View job PR Review: Refactor BRE to ERE in grep patterns
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Replace BRE (Basic Regular Expression) patterns with ERE (Extended Regular Expression) in grep commands for improved readability.
Type of Change
Component(s) Affected
Motivation and Context
BRE with escaped alternation (
grep -q "a\|b") is harder to read than ERE (grep -Eq "a|b"). The escaped pipes are:Fixes #154
Solution
Changed
grep -qtogrep -Eqfor patterns with alternation, removing the backslash escapes.Changes
validate-agent.shhook-linter.shTotal: 11 instances
Testing
🤖 Generated with Claude Code