Parse and ignore private members #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
requested changes
Oct 19, 2017
| modifiers ~ propertyName ~ optionalMarker >> { | ||
| case mods ~ name ~ optional => ( | ||
| functionSignature ^^ (FunctionMember(name, optional, _, mods)) | ||
| | typeAnnotation ^^ (PropertyMember(name, optional, _, mods)) | ||
| ) | ||
| } | ||
| } | "private" ~> propertyName ~ (functionSignature | ";") ^^^ PrivateMember |
There was a problem hiding this comment.
The semi-colon must not be there. It is already present in the definition of memberBlock.
I suggest extracting this case in a separate lazy val privateMember, and add privateMember as an alternative to typeMember rather than to namedMember.
sbrunk
force-pushed
the
private-members
branch
from
3550b1a to
95a6d44
Compare
sjrd
requested changes
Oct 19, 2017
| @@ -262,7 +262,7 @@ class TSDefParser extends StdTokenParsers with ImplicitConversions { | |||
| memberBlock ^^ ObjectType | |||
|
|
|||
| lazy val memberBlock: Parser[List[MemberTree]] = | |||
| "{" ~> rep(typeMember <~ opt(";" | ",")) <~ "}" | |||
| "{" ~> rep((typeMember | privateMember) <~ opt(";" | ",")) <~ "}" | |||
There was a problem hiding this comment.
Er, sorry, I meant as an alternative in the definition of lazy val typeMember. So a typeMember can be a callMember, etc., or a privateMember. typeMember is any kind of member than kind appear in a memberBlock.
There was a problem hiding this comment.
Ah sure, totally makes sense looking more closely. So next try :)
sbrunk
force-pushed
the
private-members
branch
from
95a6d44 to
1dff1dc
Compare
sbrunk
force-pushed
the
private-members
branch
from
1dff1dc to
b1b04ab
Compare
|
private static members can occur as well so I just added support for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler generated .d.ts files contain private methods/fields in order to avoid name collisions when subclassing in TypeScript microsoft/TypeScript#1867. The type of private fields is not included.
The approach in this PR is to just ignore them.