Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add python 3.10+ and sqlalchemy #25

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

dwikler
Copy link
Collaborator

@dwikler dwikler commented Mar 17, 2024

pynetdicom 2.1.0.dev0 requires python 3.10
upsdb.py requires sqlalchemy which is not added as a dependency of pynetdicom as listed as optional

Copy link
Owner

@sjswerdloff sjswerdloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwikler , thank you for pointing this out and being the 1st contributor!

Because this project is using poetry for dependency management, in your branch could you please:

poetry update
git add poetry.lock
git commit
git push

updates to the pyproject.toml file need to be paired with the resulting poetry.lock file...
If there are any problems with getting the lock file generated, please post the issue here and I will try to help. I use pyenv and virtualenv on MacOS 14.3/Apple Silicon and had to remove the local .venv directory and contents because it was pointing to an older version of python when I tried this out on my local machine.

Copy link
Owner

@sjswerdloff sjswerdloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you

@sjswerdloff sjswerdloff merged commit 21120a6 into sjswerdloff:main Mar 19, 2024
1 check passed
@dwikler dwikler deleted the fix-dep-issues branch March 23, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants