Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] 完善 .gitignore 文件 #251

Merged
merged 2 commits into from
Jan 8, 2018
Merged

[enhancement] 完善 .gitignore 文件 #251

merged 2 commits into from
Jan 8, 2018

Conversation

gaocegege
Copy link
Member

Close #243

@gaocegege
.gitognore: Enhance the ignore
7095bcf 
Signed-off-by: Ce Gao <ce.gao@outlook.com>
@gaocegege gaocegege requested review from at15 and AlexaraWu January 8, 2018 05:09
AlexaraWu
AlexaraWu reviewed Jan 8, 2018
View reviewed changes
Copy link
Collaborator

@AlexaraWu AlexaraWu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows 的 Thumb.db、desktop.ini 之类的也加上吧；

还有 macOS 的 Thumbnails ._* ；

这几个还是比较常见的。

@gaocegege
Copy link
Member Author

OK

@gaocegege
.gitignore: Add Windows and macOS thumbnails
c9c44d0 
Signed-off-by: Ce Gao <ce.gao@outlook.com>
@gaocegege
Copy link
Member Author

PTAL @AlexaraWu

AlexaraWu
AlexaraWu approved these changes Jan 8, 2018
View reviewed changes
Copy link
Collaborator

@AlexaraWu AlexaraWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaocegege gaocegege merged commit 46967ad into sjtug:dev Jan 8, 2018
@gaocegege gaocegege deleted the ignore branch January 8, 2018 05:49
This was referenced Jan 8, 2018
Closed
Closed
Closed
Merged
gaocegege added a commit that referenced this pull request Jan 9, 2018
@gaocegege
[enhancement] 完善 .gitignore 文件 (#251)
e68f865 
* .gitognore: Enhance the ignore

Signed-off-by: Ce Gao <ce.gao@outlook.com>

* .gitignore: Add Windows and macOS thumbnails

Signed-off-by: Ce Gao <ce.gao@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexaraWu AlexaraWu AlexaraWu approved these changes

@at15 at15 Awaiting requested review from at15

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaocegege @AlexaraWu