Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add testcases to notebook and fix generate logic for notebook deployment #16

Merged
merged 8 commits into from
Apr 22, 2021

Conversation

Mirrored90
Copy link
Collaborator

Signed-off-by: Qingyu qw90@duke.edu

Qingyu and others added 7 commits April 16, 2021 14:55
Signed-off-by: Qingyu <qw90@duke.edu>
Signed-off-by: Qingyu <qw90@duke.edu>
Signed-off-by: Qingyu <qw90@duke.edu>
Signed-off-by: Qingyu <qw90@duke.edu>
Signed-off-by: Qingyu <qw90@duke.edu>
Signed-off-by: Qingyu <qw90@duke.edu>
@Mirrored90 Mirrored90 changed the title WIP fix: Add testcases to notebook and fix generate logic for notebook deployment Apr 21, 2021
pkg/notebook/generate_test.go Outdated Show resolved Hide resolved
pkg/notebook/generate_test.go Outdated Show resolved Hide resolved
pkg/notebook/reconcile_test.go Outdated Show resolved Hide resolved
pkg/notebook/reconcile_test.go Outdated Show resolved Hide resolved
Signed-off-by: Qingyu <qw90@duke.edu>
@gaocegege gaocegege merged commit edc0711 into skai-x:master Apr 22, 2021
@Mirrored90 Mirrored90 deleted the testcases branch April 22, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants