Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PaymasterController #1083

Merged
merged 29 commits into from
Aug 28, 2024
Merged

Add PaymasterController #1083

merged 29 commits into from
Aug 28, 2024

Conversation

DimaStebaev
Copy link
Contributor

@DimaStebaev DimaStebaev commented May 31, 2024

  • added PaymasterController smart contract
  • sent message to Paymaster via PaymasterController during
    • an schain creation/removal
    • a node creation/removal
    • a validator creation/removal
  • used efficient errors in Nodes, Schains and ValidatorService
  • made all lines shorter than 100 symbols
  • deleted legacy pricing
  • PaymasterController is covered by existing unit tests
  • upgrade procedure is tested in the script/test_upgrade.sh script

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 92.12828% with 54 lines in your changes missing coverage. Please review.

Project coverage is 94.07%. Comparing base (0b319f3) to head (0332c97).

Files Patch % Lines
contracts/Nodes.sol 87.05% 11 Missing ⚠️
contracts/PaymasterController.sol 82.97% 8 Missing ⚠️
contracts/Schains.sol 84.61% 8 Missing ⚠️
contracts/delegation/TimeHelpers.sol 42.85% 8 Missing ⚠️
contracts/delegation/ValidatorService.sol 91.76% 7 Missing ⚠️
contracts/delegation/DelegationController.sol 97.11% 3 Missing ⚠️
contracts/delegation/PartialDifferences.sol 93.10% 2 Missing ⚠️
contracts/dkg/SkaleDkgAlright.sol 77.77% 2 Missing ⚠️
contracts/dkg/SkaleDkgPreResponse.sol 84.61% 2 Missing ⚠️
contracts/SkaleVerifier.sol 66.66% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##           v1.12.0    #1083      +/-   ##
===========================================
- Coverage    95.11%   94.07%   -1.05%     
===========================================
  Files           40       40              
  Lines         2865     2985     +120     
  Branches       675      691      +16     
===========================================
+ Hits          2725     2808      +83     
- Misses         140      177      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DimaStebaev DimaStebaev marked this pull request as ready for review August 9, 2024 12:44
yavrsky
yavrsky previously approved these changes Aug 12, 2024
Copy link
Contributor

@DmytroNazarenko DmytroNazarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add description of the tests in PR

contracts/Schains.sol Show resolved Hide resolved
@DimaStebaev DimaStebaev merged commit 37ff5da into v1.12.0 Aug 28, 2024
7 of 9 checks passed
@DimaStebaev DimaStebaev deleted the paymaster branch August 28, 2024 07:42
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically update contracts on Europa with changes from SKALE Manager on Ethereum via IMA
3 participants