Feature/skale 4448 allow wallets store skl #653
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub.com/skalenetwork/skale-manager into enhancement/SKALE-2510-adopt-private-keys
…t-private-keys Enhancement/skale 2510 adopt private keys
…events Enhancement/skale 3785 add events
Bumps [web3](https://github.com/ethereum/web3.js) from 1.4.0 to 1.5.1. - [Release notes](https://github.com/ethereum/web3.js/releases) - [Changelog](https://github.com/ChainSafe/web3.js/blob/1.x/CHANGELOG.md) - [Commits](web3/web3.js@v1.4.0...v1.5.1) --- updated-dependencies: - dependency-name: web3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…3-1.5.1 Bump web3 from 1.4.0 to 1.5.1
Bumps [ethers](https://github.com/ethers-io/ethers.js/tree/HEAD/packages/ethers) from 5.4.2 to 5.4.4. - [Release notes](https://github.com/ethers-io/ethers.js/releases) - [Changelog](https://github.com/ethers-io/ethers.js/blob/master/CHANGELOG.md) - [Commits](https://github.com/ethers-io/ethers.js/commits/v5.4.4/packages/ethers) --- updated-dependencies: - dependency-name: ethers dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…ers-5.4.4 Bump ethers from 5.4.2 to 5.4.4
Codecov Report
@@ Coverage Diff @@
## feature/SKALE-3749-schain-pricing #653 +/- ##
==================================================================
Coverage 95.39% 95.40%
==================================================================
Files 38 38
Lines 2584 2611 +27
Branches 414 409 -5
==================================================================
+ Hits 2465 2491 +26
- Misses 119 120 +1
Continue to review full report at Codecov.
|
DimaStebaev
requested changes
Sep 3, 2021
| // /** | ||
| // * @dev Returns the current price in SKL tokens for given Schain type and lifetime. | ||
| // */ | ||
| // function getSchainPrice(uint typeOfSchain, uint lifetime) public view returns (uint) { |
| msg.sender.transfer(amount); | ||
| } | ||
|
|
||
| function storeSchainDeposit(bytes32 schainHash, uint deposit) external allow("Schains") { | ||
| _schainDeposits[schainHash] += deposit; |
| msg.sender.transfer(amount); | ||
| } | ||
|
|
||
| function storeSchainDeposit(bytes32 schainHash, uint deposit) external allow("Schains") { |
There was a problem hiding this comment.
"IncreaseSchainDeposit"?
…448-allow-wallets-store-skl
yavrsky
force-pushed
the
feature/SKALE-4448-allow-wallets-store-skl
branch
from
7699f7b to
7b540ec
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Wallets to store SKL