Enhancement/499 node exit for ngc nodes #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavrsky
requested review from
payvint,
kladkogex and
DimaStebaev
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #905 +/- ##
========================================
Coverage 95.35% 95.36%
========================================
Files 38 38
Lines 2844 2847 +3
Branches 669 669
========================================
+ Hits 2712 2715 +3
Misses 132 132
|
DimaStebaev
reviewed
Jan 3, 2023
test/SkaleManager.ts
Outdated
| @@ -245,6 +245,13 @@ describe("SkaleManager", () => { | |||
| await nodesContract.isNodeLeft(0).should.be.eventually.true; | |||
| }); | |||
|
|
|||
| it("should perform nodeExit if validator unlinked his node", async () => { | |||
There was a problem hiding this comment.
Not node but node address.
payvint
previously approved these changes
Jan 3, 2023
… into enhancement/499-node-exit-for-ngc-nodes
…hub.com/skalenetwork/skale-manager into enhancement/499-node-exit-for-ngc-nodes
DimaStebaev
previously approved these changes
Jun 16, 2023
DimaStebaev
approved these changes
Aug 14, 2023
payvint
approved these changes
Aug 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.