Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/skale 4942 Fix incorrect finish_ts in rotation history #473

Merged
merged 3 commits into from
Feb 4, 2022

Conversation

dmytrotkk
Copy link
Collaborator

No description provided.

@dmytrotkk dmytrotkk requested a review from badrogger February 4, 2022 09:38
@dmytrotkk dmytrotkk requested a review from kladkogex as a code owner February 4, 2022 09:38
@dmytrotkk dmytrotkk self-assigned this Feb 4, 2022
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #473 (2f6ad56) into develop (8180bba) will decrease coverage by 0.00%.
The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #473      +/-   ##
===========================================
- Coverage    86.60%   86.59%   -0.01%     
===========================================
  Files           66       66              
  Lines         2344     2350       +6     
===========================================
+ Hits          2030     2035       +5     
- Misses         314      315       +1     
Impacted Files Coverage Δ
skale/schain_config/rotation_history.py 100.00% <ø> (ø)
skale/contracts/manager/node_rotation.py 92.18% <90.90%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8180bba...2f6ad56. Read the comment docs.

@dmytrotkk dmytrotkk merged commit 56f777d into develop Feb 4, 2022
@dmytrotkk dmytrotkk deleted the hotfix/SKALE-4942-incorrect-finish-ts-rotation branch February 4, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants