Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints #557

Merged
merged 102 commits into from
May 27, 2024
Merged

Add type hints #557

merged 102 commits into from
May 27, 2024

Conversation

DimaStebaev
Copy link
Contributor

@DimaStebaev DimaStebaev commented Apr 5, 2024

Add type hints

@DimaStebaev DimaStebaev linked an issue Apr 5, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 85.48387% with 189 lines in your changes are missing coverage. Please review.

Project coverage is 86.25%. Comparing base (794a1b0) to head (f408e01).

Files Patch % Lines
skale/contracts/allocator/allocator.py 0.00% 62 Missing ⚠️
skale/contracts/allocator/escrow.py 0.00% 23 Missing ⚠️
skale/utils/contracts_provision/allocator.py 0.00% 11 Missing ⚠️
skale/wallets/redis_wallet.py 70.37% 8 Missing ⚠️
skale/contracts/ima/linker.py 0.00% 7 Missing ⚠️
skale/skale_allocator.py 53.33% 7 Missing ⚠️
skale/schain_config/rotation_history.py 71.42% 6 Missing ⚠️
skale/contracts/manager/nodes.py 91.93% 5 Missing ⚠️
skale/dataclasses/node_info.py 0.00% 5 Missing ⚠️
skale/skale_ima.py 61.53% 5 Missing ⚠️
... and 22 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #557      +/-   ##
===========================================
- Coverage    90.99%   86.25%   -4.74%     
===========================================
  Files           64       73       +9     
  Lines         2464     2902     +438     
===========================================
+ Hits          2242     2503     +261     
- Misses         222      399     +177     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DimaStebaev DimaStebaev marked this pull request as ready for review May 21, 2024 12:47
skale/contracts/allocator/allocator.py Outdated Show resolved Hide resolved
skale/contracts/manager/delegation/validator_service.py Outdated Show resolved Hide resolved
skale/schain_config/rotation_history.py Outdated Show resolved Hide resolved
skale/skale_manager.py Show resolved Hide resolved
@badrogger badrogger merged commit 0e63517 into develop May 27, 2024
6 of 8 checks passed
@badrogger badrogger deleted the types branch May 27, 2024 12:44
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add type hints
3 participants