Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutdown snapshot hash computation at exit #1532

Closed
dimalit opened this issue May 23, 2023 · 2 comments · Fixed by #1543
Closed

Shutdown snapshot hash computation at exit #1532

dimalit opened this issue May 23, 2023 · 2 comments · Fixed by #1543
Assignees
@dimalit
Labels
enhancement New feature or request release:2.2

Comments

@dimalit
Copy link
Contributor

dimalit commented May 23, 2023

When skaled is about to exit, it can happen that at the same time it's in the process of computing hash of snapshot. As this computation can take significantly long time (hours), we need to terminate this computation is some way. At next skaled start it should start snapshot hash computation all over again.
Also consider the case when skaled is computing hash of snapshot that it has just downloaded.
@dimalit dimalit self-assigned this May 23, 2023
@dimalit dimalit mentioned this issue May 23, 2023
Closed
@DmytroNazarenko DmytroNazarenko added the enhancement New feature or request label May 23, 2023
@DmytroNazarenko DmytroNazarenko moved this to In Progress in SKALE Engineering 🚀 May 25, 2023
@olehnikolaiev olehnikolaiev mentioned this issue Jun 16, 2023
Merged
@olehnikolaiev olehnikolaiev moved this from In Progress to Code Review in SKALE Engineering 🚀 Jun 16, 2023
@DmytroNazarenko DmytroNazarenko moved this from Code Review to Ready For Release Candidate in SKALE Engineering 🚀 Jun 16, 2023
@DmytroNazarenko DmytroNazarenko mentioned this issue Jun 20, 2023
Merged
@DmytroNazarenko
Copy link
Collaborator

skaled: 3.17.0-beta.1

@DmytroNazarenko DmytroNazarenko moved this from Ready For Release Candidate to Merged To Release Candidate in SKALE Engineering 🚀 Jun 21, 2023
@EvgeniyZZ EvgeniyZZ moved this from Merged To Release Candidate to QA in SKALE Engineering 🚀 Jun 21, 2023
@OleksanderSalamatov
Copy link

Duplicate of #1525

@OleksanderSalamatov OleksanderSalamatov marked this as a duplicate of #1525 Aug 29, 2023
@EvgeniyZZ EvgeniyZZ moved this from QA to Done in SKALE Engineering 🚀 Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimalit dimalit

Labels
enhancement New feature or request release:2.2
Projects
SKALE Engineering 🚀
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhancement/skaled 1425 threading rules skalenetwork/skaled
3 participants
@dimalit @DmytroNazarenko @OleksanderSalamatov