Enhancement/skaled 1425 threading rules #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-1425-threading-rules
…-1425-threading-rules
olehnikolaiev
requested review from
DmytroNazarenko and
kladkogex
as code owners
|
SUGGESTIONS BEFORE MERGE:
|
| @@ -115,7 +115,7 @@ jobs: | |||
| export CMAKE_BUILD_TYPE=Release | |||
| cd build | |||
| make skaled -j$(nproc) | |||
| echo "Ensure release mode skaled does not have any debug markers" | |||
| #echo "Ensure release mode skaled does not have any debug markers" | |||
There was a problem hiding this comment.
Do you need this comment?
There was a problem hiding this comment.
I think it is not needed
kladkogex
approved these changes
Jun 16, 2023
sergiy-skalelabs
approved these changes
Jun 16, 2023
DmytroNazarenko
approved these changes
Jun 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1415
fixes #1348
fixes #1532