Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve data destruction in Level DB #1644

Closed
PolinaKiporenko opened this issue Sep 11, 2023 · 1 comment · Fixed by #1661
Closed

Improve data destruction in Level DB #1644

PolinaKiporenko opened this issue Sep 11, 2023 · 1 comment · Fixed by #1661
Assignees
@kladkogex
Labels
enhancement New feature or request epic:HPD

Comments

@PolinaKiporenko
Copy link
Contributor

There was an ineffective algorithm for data destruction in EVM that got fixed.

We iterate over LevelDB keys belonging to the account that has been destroyed and remove them

@kladkogex please add more description
@PolinaKiporenko PolinaKiporenko added enhancement New feature or request epic:HPD labels Sep 11, 2023
@DmytroNazarenko DmytroNazarenko mentioned this issue Sep 12, 2023
Closed
1 task
@kladkogex
Copy link
Collaborator

kladkogex commented Sep 12, 2023 •
edited
Loading

There are two levels at which data
destruction happens:

  1. EVM call delete keys of LevelDB - there was a bug in this that has been fixed. Note that there is a patch that needs to be enabled.

  2. If keys are destroyed, sometimes LevelDB does not shrink the LevelDB file where the keys are stored. This is a separate problem

@kladkogex kladkogex linked a pull request Sep 21, 2023 that will close this issue
1347 data destruction #1661
Merged
@github-project-automation github-project-automation bot moved this to Ready For Release Candidate in SKALE Engineering 🚀 Sep 21, 2023
kladkogex added a commit that referenced this issue Dec 4, 2023
@kladkogex
#1644 addressed pull request comments
f83d7a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kladkogex kladkogex

Labels
enhancement New feature or request epic:HPD
Projects
SKALE Engineering 🚀
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1347 data destruction skalenetwork/skaled
2 participants
@kladkogex @PolinaKiporenko