Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IS-711 Release consensusWorkingMutex in createBlock #1427

Merged
merged 3 commits into from
Feb 21, 2023
Merged

IS-711 Release consensusWorkingMutex in createBlock #1427

merged 3 commits into from
Feb 21, 2023

Conversation

dimalit
Copy link
Contributor

@dimalit dimalit commented Feb 20, 2023

related to skaled's hang on exit if exited by exit timeout reached

@dimalit dimalit requested a review from a team as a code owner February 20, 2023 15:34
@github-actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@dimalit dimalit linked an issue Feb 20, 2023 that may be closed by this pull request
Skaled doesn't exit gracefully after rotation delay time #1415
Closed
@DmytroNazarenko DmytroNazarenko merged commit 9d9553d into develop Feb 21, 2023
@DmytroNazarenko DmytroNazarenko deleted the bug/IS-711-exit-from-createBlock branch February 21, 2023 11:58
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sergiy-skalelabs sergiy-skalelabs sergiy-skalelabs approved these changes

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

@kladkogex kladkogex kladkogex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skaled doesn't exit gracefully after rotation delay time
4 participants
@dimalit @kladkogex @DmytroNazarenko @sergiy-skalelabs