Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1425 Threading rules #1514

Closed
wants to merge 1 commit into from
Closed

1425 Threading rules #1514

wants to merge 1 commit into from

Conversation

kladkogex
Copy link
Collaborator

No description provided.

@kladkogex kladkogex requested a review from a team as a code owner May 4, 2023 10:10
@github-actions
Copy link

github-actions bot commented May 4, 2023

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@kladkogex kladkogex linked an issue May 4, 2023 that may be closed by this pull request
Establish threading rules in skaled-consensus interaction #1425
Closed
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #1514 (6e63c9f) into v3.17.0 (75b2fb9) will decrease coverage by 1.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           v3.17.0    #1514      +/-   ##
===========================================
- Coverage    45.25%   44.09%   -1.17%     
===========================================
  Files          335      335              
  Lines        50962    50962              
===========================================
- Hits         23062    22470     -592     
- Misses       27900    28492     +592

dimalit
dimalit suggested changes May 4, 2023
View reviewed changes
Copy link
Contributor

@dimalit dimalit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is WRONG branch!
Correct one is enhancement/SKALED-1425-threading-rules

@dimalit dimalit closed this May 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
@kladkogex kladkogex deleted the 1425_threading_rules branch October 19, 2023 12:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dimalit dimalit dimalit requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Establish threading rules in skaled-consensus interaction
2 participants
@kladkogex @dimalit