Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket 1511/remove un needed skaled parts for release 2.2 and fix warnings #1521

Merged
merged 4 commits into from
May 16, 2023
Merged

Ticket 1511/remove un needed skaled parts for release 2.2 and fix warnings #1521

merged 4 commits into from
May 16, 2023

Conversation

sergiy-skalelabs
Copy link
Contributor

Removed un-needed skaled parts for release 2.2, all the un-needed skale_ima*** JSON RPC APIs were removed.

@sergiy-skalelabs sergiy-skalelabs requested a review from a team as a code owner May 10, 2023 14:56
@github-actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@sergiy-skalelabs sergiy-skalelabs self-assigned this May 10, 2023
@sergiy-skalelabs sergiy-skalelabs added this to the 2.2 milestone May 10, 2023
@sergiy-skalelabs sergiy-skalelabs linked an issue May 10, 2023 that may be closed by this pull request
Remove un-needed skaled parts for release 2.2. #1511
Closed
@DmytroNazarenko DmytroNazarenko removed this from the 2.2 milestone May 10, 2023
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #1521 (302e224) into v3.17.0 (75b2fb9) will decrease coverage by 1.22%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           v3.17.0    #1521      +/-   ##
===========================================
- Coverage    45.33%   44.11%   -1.22%     
===========================================
  Files          335      335              
  Lines        50962    50976      +14     
===========================================
- Hits         23103    22490     -613     
- Misses       27859    28486     +627

@sergiy-skalelabs sergiy-skalelabs added this to the 2.2 milestone May 15, 2023
@kladkogex kladkogex changed the title Ticket 1511/remove un needed skaled parts for release 2.2 Ticket 1511/remove un needed skaled parts for release 2.2 and fix warnings May 16, 2023
@sergiy-skalelabs sergiy-skalelabs merged commit 942efeb into v3.17.0 May 16, 2023
@sergiy-skalelabs sergiy-skalelabs deleted the ticket-1511/remove-un-needed-skaled-parts-for-release-2.2 branch May 16, 2023 14:39
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kladkogex kladkogex kladkogex approved these changes

@dimalit dimalit dimalit approved these changes

@DmytroNazarenko DmytroNazarenko Awaiting requested review from DmytroNazarenko

@olehnikolaiev olehnikolaiev Awaiting requested review from olehnikolaiev

Assignees

@sergiy-skalelabs sergiy-skalelabs

Labels
skaled
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

Remove un-needed skaled parts for release 2.2.
4 participants
@sergiy-skalelabs @dimalit @kladkogex @DmytroNazarenko