Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lcov #1535

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Remove lcov #1535

merged 1 commit into from
Jun 1, 2023

Conversation

dimalit
Copy link
Contributor

@dimalit dimalit commented Jun 1, 2023

lcov installation in "Custom skaled container" is broken. As it is not needed, will remove it

@dimalit dimalit requested a review from a team as a code owner June 1, 2023 11:37
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@dimalit dimalit linked an issue Jun 1, 2023 that may be closed by this pull request
Establish threading rules in skaled-consensus interaction #1425
Closed
@dimalit dimalit merged commit 64070c9 into v3.17.0 Jun 1, 2023
@dimalit dimalit deleted the bug/remove-lcov-from-custom-build branch June 1, 2023 18:38
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sergiy-skalelabs sergiy-skalelabs sergiy-skalelabs approved these changes

@olehnikolaiev olehnikolaiev olehnikolaiev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Establish threading rules in skaled-consensus interaction
3 participants
@dimalit @olehnikolaiev @sergiy-skalelabs