Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/is 552 zmq assert #1948

Merged
merged 8 commits into from
Aug 6, 2024
Merged

Bug/is 552 zmq assert #1948

merged 8 commits into from
Aug 6, 2024

Conversation

dimalit
Copy link
Contributor

@dimalit dimalit commented Jul 18, 2024 •
edited
Loading

Removed ZMQ_HEARBEAT in boradcaster. TCP_KEEPALIVE is stil there

see testing description in comments in issue

performance impact: absent

@github-actions GitHub Actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@dimalit dimalit marked this pull request as ready for review July 23, 2024 18:29
@dimalit dimalit merged commit 39b6d8e into v3.20.0 Aug 6, 2024
4 of 5 checks passed
@dimalit dimalit deleted the bug/IS-552-zmq-assert branch August 6, 2024 12:26
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2024
@DmytroNazarenko DmytroNazarenko restored the bug/IS-552-zmq-assert branch November 22, 2024 12:35
@DmytroNazarenko DmytroNazarenko deleted the bug/IS-552-zmq-assert branch November 22, 2024 12:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kladkogex kladkogex kladkogex approved these changes

@olehnikolaiev olehnikolaiev olehnikolaiev approved these changes

@DmytroNazarenko DmytroNazarenko Awaiting requested review from DmytroNazarenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimalit @kladkogex @olehnikolaiev