Code improvements

app/controllers/notifications_controller.rb

@@ -4,8 +4,7 @@ def index
 
   def show
     notification = Notification.find params[:id]
-    notification.is_read = true
-    notification.save
+    Notification.mark_as_read notification
     redirect_to notification.source
   end
 end

app/models/generates_notifications.rb

@@ -1,13 +1,13 @@
 module GeneratesNotifications
-    extend self
+  extend self
 
-    def generate_notifications_for(users, title:)
-        users.each do |user|
-          notification = Notification.new
-          notification.title = title
-          notification.source = self
-          notification.user = user
-          notification.save
-        end
+  def generate_notifications_for(users, title:)
+    users.find_each do |user|
+      notification = Notification.new
+      notification.title = title
+      notification.source = self
+      notification.user = user
+      notification.save!
     end
+  end
 end

app/models/notification.rb

@@ -6,5 +6,10 @@ class << self
     def unread_for_user(id)
       where(user_id: id, is_read: false)
     end
+
+    def mark_as_read(notification)
+      notification.is_read = true
+      notification.save!
+    end
   end
 end