Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ScrollContainer] [Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. #1326

Closed
nextgennexia opened this issue Apr 4, 2019 · 2 comments · Fixed by #1330
Closed

[ScrollContainer] [Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. #1326

nextgennexia opened this issue Apr 4, 2019 · 2 comments · Fixed by #1330
Assignees
@wKich
Labels
bug

Comments

@nextgennexia
Copy link

Версия: 0.45.0
Браузер: chrome

Скроллить вверх, когда список максимально вверху / скроллить вниз, когда список максимально внизу
image
@wKich
Copy link
Member

wKich commented Apr 4, 2019

Похоже прилетело с новой версией хрома. Воспроизводится даже на старых версиях библиотеки

@wKich
Copy link
Member

wKich commented Apr 4, 2019

Вот тут выкатилось https://www.chromestatus.com/features/6662647093133312

И react не поддерживает пока листнеров с passive: true facebook/react#6436

Тут вот ещё обсуждают facebook/react#14856

@wKich wKich added the bug label Apr 4, 2019
@wKich wKich changed the title [ComboBox] [Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. [ScrollContainer] [Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. Apr 5, 2019
@wKich wKich self-assigned this Apr 8, 2019
wKich added a commit that referenced this issue Apr 8, 2019
@wKich
fix: preventDefault inside passive event listener
055eb48 
Hotfix workaround for chrome 73 https://www.chromestatus.com/features/6662647093133312. Due react
don't support passive event listener we are subscribe on these events through `addEventListener`
with `{ passive: false }` option. Current status of supporting passive events in react
facebook/react#6436

fix #1326
@wKich wKich mentioned this issue Apr 8, 2019
Merged
@zhzz zhzz closed this as completed in #1330 Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wKich wKich

Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(retail-ui): preventDefault inside passive event listener skbkontur/retail-ui
2 participants
@wKich @nextgennexia