Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Input] не работают вместе пропы autoFocus и selectAllOnFocus #1413

Closed
evifox opened this issue May 15, 2019 · 1 comment · Fixed by #1496
Closed

[Input] не работают вместе пропы autoFocus и selectAllOnFocus #1413

evifox opened this issue May 15, 2019 · 1 comment · Fixed by #1496
Assignees
@lossir
Labels
bug LTS

Comments

@evifox
Copy link

evifox commented May 15, 2019 •
edited
Loading

Параметры:

  • retail-ui 0.49.0;
  • Google Chrome Version 69.0.3497.100 (Official Build) (64-bit), Win10;
  • При появлении инпута срабатывает автофокус, но не срабатывает выделение. Но если переключить вкладку и вернуться обратно, то текст будет выделен. Также выделение срабатывает, если фокуситься вручную;
  • <Input autoFocus selectAllOnFocus value="value" />;
@zhzz zhzz added the bug label May 15, 2019
@zhzz
Copy link
Member

zhzz commented May 15, 2019

Вот в чем дело.

lossir added a commit that referenced this issue Jul 9, 2019
@lossir
fix(Input): add calling 'selectAll' via 'setTimeout'
f2b7226 
facebook/react#7769

Fix #1413
@lossir lossir mentioned this issue Jul 9, 2019
Merged
lossir added a commit that referenced this issue Jul 11, 2019
@lossir
fix(Input): add calling 'selectAll' via 'raf' (#1496)
37b866d 
* fix(Input): add calling 'selectAll' via 'setTimeout'

facebook/react#7769

Fix #1413

* test(Input): add delay(0) when testing 'selectAllOnFocus'

* refactor(Input): use 'raf' instead of 'setTimeout'

* test(Input): raise the delay time due to 'raf'

* refactor(Input): return partially previous implementation
@dzekh dzekh added the LTS label Jul 16, 2019
lossir added a commit that referenced this issue Jul 16, 2019
@lossir
fix(Input): add calling 'selectAll' via 'raf'
7f841d1 
Fix #1413
@lossir lossir mentioned this issue Jul 16, 2019
Merged
@lossir lossir self-assigned this Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lossir lossir

Labels
bug LTS
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Input): add calling 'selectAll' via 'raf' skbkontur/retail-ui
4 participants
@lossir @zhzz @dzekh @evifox